Repository navigation
[Component] Rename redisue to residual - #6434
Merged
Merged
Conversation
th-skam
added
pr: fast merge
Contributor
|
Do we see a pattern of a specific individual doing the same mistake over and over ? I don't know... That is just some old work residue... |
Contributor
|
More seriously, I cannot see any scene modification in your PR, could you make sure this is not used in any scenes and re-run the ci with all tests ? |
Contributor
Author
|
[ci-build][with-all-tests] I didn't find any reference in scenes. They're ran with defaults. |
Contributor
|
No there's no need for throwing any ci-build or test tags in comment. In the commit body is enough now. Just the regression tests (and the scene tests but not for long) will fail on windows and it might be unrelated so for windows focus on unit tests... |
th-skam
added
pr: status wip
fredroy
reviewed
Nov 3, 2026
fredroy
approved these changes
Nov 5, 2026
hugtalbot
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frenchified version of residual is inconvenient; gets missed by searches. Better now, before release.
[with-all-tests]